Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: Source/core/dom/SelectorQuery.cpp

Issue 1099963003: Support type selector for camel-cased SVG elements in HTML. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix performance regression. tagMatches() became too big to be inlined on Linux. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/css/SelectorFilter.cpp ('K') | « Source/core/dom/SelectorQuery.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/SelectorQuery.cpp
diff --git a/Source/core/dom/SelectorQuery.cpp b/Source/core/dom/SelectorQuery.cpp
index 2dda9c39f1d47402f223fa8c94c97f9f6290d646..e190720d677a3cd183b3fd16ba5c6c17307fe833 100644
--- a/Source/core/dom/SelectorQuery.cpp
+++ b/Source/core/dom/SelectorQuery.cpp
@@ -176,10 +176,10 @@ void SelectorDataList::collectElementsByClassName(ContainerNode& rootNode, const
}
template <typename SelectorQueryTrait>
-void SelectorDataList::collectElementsByTagName(ContainerNode& rootNode, const QualifiedName& tagName, typename SelectorQueryTrait::OutputType& output) const
+void SelectorDataList::collectElementsByTagName(ContainerNode& rootNode, const CSSSelector& tagSelector, typename SelectorQueryTrait::OutputType& output) const
{
for (Element& element : ElementTraversal::descendantsOf(rootNode)) {
- if (SelectorChecker::tagMatches(element, tagName)) {
+ if (SelectorChecker::tagMatches(element, tagSelector)) {
SelectorQueryTrait::appendElement(output, element);
if (SelectorQueryTrait::shouldOnlyMatchFirstElement)
return;
@@ -468,7 +468,7 @@ void SelectorDataList::execute(ContainerNode& rootNode, typename SelectorQueryTr
collectElementsByClassName<SelectorQueryTrait>(rootNode, firstSelector.value(), output);
return;
case CSSSelector::Tag:
- collectElementsByTagName<SelectorQueryTrait>(rootNode, firstSelector.tagQName(), output);
+ collectElementsByTagName<SelectorQueryTrait>(rootNode, firstSelector, output);
return;
default:
break; // If we need another fast path, add here.
« Source/core/css/SelectorFilter.cpp ('K') | « Source/core/dom/SelectorQuery.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698