Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1099873002: Undo the bounds mapping of bounds for GrOvalRenderer for certain draws (Closed)

Created:
5 years, 8 months ago by egdaniel
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Undo the bounds mapping of bounds for GrOvalRenderer for certain draws BUG=skia: Committed: https://skia.googlesource.com/skia/+/bc227140ffea6eb15e2e8b147eb6d8ec6228d95a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Missed mapRect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 12 chunks +12 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
We were a little over zealous in our bounds mapping yesterday. Seems like everything besides ...
5 years, 8 months ago (2015-04-21 13:17:47 UTC) #2
joshualitt
On 2015/04/21 13:17:47, egdaniel wrote: > We were a little over zealous in our bounds ...
5 years, 8 months ago (2015-04-21 13:18:56 UTC) #3
joshualitt
https://codereview.chromium.org/1099873002/diff/1/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/1099873002/diff/1/src/gpu/GrOvalRenderer.cpp#newcode2227 src/gpu/GrOvalRenderer.cpp:2227: viewMatrix.mapRect(&bounds); remove
5 years, 8 months ago (2015-04-21 13:19:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099873002/20001
5 years, 8 months ago (2015-04-21 13:22:42 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 13:28:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bc227140ffea6eb15e2e8b147eb6d8ec6228d95a

Powered by Google App Engine
This is Rietveld 408576698