Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressed kbr@'s feedback: get the 'correct' framebuffer bound to give target Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLRenderingContextBase.h
diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h
index 5217ebbb96bff676b23fde4166fab2ad8d98eca5..c106209381aa503efd8a2e013e5be8f67c6d96c0 100644
--- a/Source/core/html/canvas/WebGLRenderingContextBase.h
+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h
@@ -881,6 +881,12 @@ protected:
// used only to warn about use of obsolete functions.
void printWarningToConsole(const String&);
+ // Helper function to validate the target for checkFramebufferStatus and validateFramebufferFuncParameters.
+ virtual bool validateFramebufferTarget(GLenum target);
+
+ // Get the framebuffer bound to given target
+ virtual RefPtrWillBeMember<WebGLFramebuffer> getFramebufferBinding(GLenum target);
Ken Russell (switch to Gerrit) 2015/04/30 01:41:51 I don't think it's necessary or correct to return
yunchao 2015/04/30 02:42:49 Done.
+
// Helper function to validate input parameters for framebuffer functions.
// Generate GL error if parameters are illegal.
bool validateFramebufferFuncParameters(const char* functionName, GLenum target, GLenum attachment);
« no previous file with comments | « Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698