Issue 109983006: Remove calls of PrerenderTracker::TryCancel on UI thread and instead have them call PrerenderConten…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109983006: Remove calls of PrerenderTracker::TryCancel on UI thread and instead have them call PrerenderConten… (Closed)

Created:
6 years, 11 months ago by jam

Modified:
6 years, 11 months ago

Reviewers:
tburkard

CC:
chromium-reviews, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove calls of PrerenderTracker::TryCancel on UI thread and instead have them call PrerenderContents::Destroy directly. This is part of the work on removing calls to ResourceRequestInfo::GetAssociatedRenderView. The last callers to that method are using it to cancel prerenders if they haven't been used yet, so the checking/cancelling needs to all move to the UI thread. BUG=304341 R=tburkard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243094

Patch Set 1 #

Patch Set 2 : sync #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -16 lines)			Patch
	M	chrome/browser/chrome_content_browser_client.cc	View	1	1 chunk	+7 lines, -12 lines	0 comments	Download
	M	chrome/browser/prerender/prerender_manager.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages