fixes #146, JS globals were not understood by the renamer

fixes #146, JS globals were not understood by the renamer

there are two basic strategies to fix: we either provide globals to the renamer, or it determines them based on use. I went with the second approach, as it fits more naturally with the current code generator.

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/8cb39fcb122dfcf9d9244b9637196030b907fcd9

[Jennifer Messerly, 2015-04-22 16:14:03]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2015-04-22 16:15:12]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-04-22 16:19:53]

https://codereview.chromium.org/1099813006/diff/20001/lib/src/codegen/js_name...
File lib/src/codegen/js_names.dart (left):

https://codereview.chromium.org/1099813006/diff/20001/lib/src/codegen/js_name...
lib/src/codegen/js_names.dart:66: visitIdentifier(Identifier node) {
previously, we simply recorded usage of a name, and then later
(_allNamesInScope) decided that the variable was "declared" at the top usage
scope. That works fine for locals, but not for globals.

now, we walk up to the declaration site. If the variable is not declared, we
assume it is a global. So things like "dart" (dart_runtime.js) are determined to
be globals automatically

[vsm, 2015-04-22 16:30:05]

lgtm

What do you think about listing the expected global symbols in the output?  In a
different module format, it'd possibly be explicit, but it could be comments at
the top for now.  This could be handy deciphering the output:

// Implicit imports:
// - core : 'dart:core'
// - collections: 'dart:collections'
// ...

[Jennifer Messerly, 2015-04-22 17:42:28]

On 2015/04/22 16:30:05, vsm wrote:
> lgtm
> 
> What do you think about listing the expected global symbols in the output?  In
a
> different module format, it'd possibly be explicit, but it could be comments
at
> the top for now.  This could be handy deciphering the output:
> 
> // Implicit imports:
> // - core : 'dart:core'
> // - collections: 'dart:collections'
> // ...

yeah that's a really good idea. filed
https://github.com/dart-lang/dev_compiler/issues/149

[Jennifer Messerly, 2015-04-22 17:43:58]

Committed patchset #1 (id:20001) manually as
8cb39fcb122dfcf9d9244b9637196030b907fcd9 (presubmit successful).