fix fields that override getters/setters

fix fields that override getters/setters

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4c5c6184fc9ee72840bdeb902d0c9dee4ab4542a

[Jennifer Messerly, 2015-04-20 23:55:30]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2015-04-20 23:55:35]

Patchset #2 (id:40001) has been deleted

[Jennifer Messerly, 2015-04-20 23:55:40]

Patchset #1 (id:20001) has been deleted

[Jennifer Messerly, 2015-04-20 23:58:57]

jmesserly@google.com changed reviewers:
+ jacobr@google.com, leafp@google.com

[Jennifer Messerly, 2015-04-20 23:58:58]

fyi, this is similar to CL https://codereview.chromium.org/1090313002/, but
doesn't contain the a fix for non-sealed fields. Result is (much) simpler.

I also noticed the original CL was doing more work than needed, because it
wasn't stopping at an abstract getter/setter and was analyzing synthetic fields.

[Leaf, 2015-04-21 15:31:50]

I'm still a little hesitant about forbidding overriding a field with
getter/setter, but I think this is a good place to start from and we can revisit
this if it proves too restrictive.  LGTM.

[Jennifer Messerly, 2015-04-21 15:52:31]

On 2015/04/21 15:31:50, leafp wrote:
> I'm still a little hesitant about forbidding overriding a field with
> getter/setter, 

Me too.

> but I think this is a good place to start from and we can revisit
> this if it proves too restrictive.  LGTM.

Yeah, I think with a few tweaks in a follow up we could basically get it
working, as long as we only have one initializer. And we can fix multiple
initializers with the initField change:

https://codereview.chromium.org/1093143004/diff/20001/lib/runtime/dart_runtim...
https://codereview.chromium.org/1093143004/diff/20001/test/codegen/fields.dart

[Jennifer Messerly, 2015-04-21 16:07:26]

Committed patchset #2 (id:80001) manually as
4c5c6184fc9ee72840bdeb902d0c9dee4ab4542a (presubmit successful).

[Jacob, 2015-04-21 16:21:01]

lgtm