chrome/browser/resources/file_manager/foreground/js/directory_model.js - Issue 109973002: Migrate from URLs to Entries in the Files App's gallery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/foreground/js/directory_model.js

Issue 109973002: Migrate from URLs to Entries in the Files App's gallery. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleaned up. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/foreground/js/file_tasks.js » ('j') | chrome/browser/resources/file_manager/foreground/js/file_tasks.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/file_manager/foreground/js/directory_model.js

diff --git a/chrome/browser/resources/file_manager/foreground/js/directory_model.js b/chrome/browser/resources/file_manager/foreground/js/directory_model.js

index 5ea32a7099bd17fb44bb9aca46cc80cce22c0cd3..179f84c99a1997611a3c862ff652df9ae137aad3 100644

--- a/chrome/browser/resources/file_manager/foreground/js/directory_model.js

+++ b/chrome/browser/resources/file_manager/foreground/js/directory_model.js

@@ -939,9 +939,11 @@ DirectoryModel.prototype.selectEntry = function(entry) {

};

/**

- * @param {Array.<string>} urls Array of URLs.

+ * @param {Array.<string>} entries Array of URLs.

hirono 2013/12/09 06:53:50 nit: Please fix the comment.

mtomasz 2013/12/10 02:37:34 Done.

-DirectoryModel.prototype.selectUrls = function(urls) {

+DirectoryModel.prototype.selectEntries = function(entries) {

+ // URLs are needed here, since we are comparing Entries by URLs.

+ var urls = util.entriesToURLs(entries);

var fileList = this.getFileList();

this.fileListSelection_.beginChange();

this.fileListSelection_.unselectAll();