Migrate from URLs to Entries in the Files App's gallery.

Migrate from URLs to Entries in the Files App's gallery.

This patch migrates from URLs in favor of Entries, wherever possible.

TEST=Tested manually. Renamed, modified an image, deleted an image.
BUG=326901
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240098

[mtomasz, 2013-12-09 06:13:44]

@hirono: PTAL. Thanks.

[hirono, 2013-12-09 06:53:50]

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/directory_model.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/directory_model.js:942: *
@param {Array.<string>} entries Array of URLs.
nit: Please fix the comment.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/directory_model.js:951: if
(urls.indexOf(fileList.item(i).toURL()) >= 0)
1. Is it also needed to select child entries?

2. How about the following case?
url: http://xxx/drive/root/ABC
listItem: http://xxx/drive/root/A

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:674: //
TODO(mtomasz): Pass entries instead.
nit: The TODO has already done!

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js:560:
return this.isBusy() && (this.entry_.toURL() == entry.toURL());
nit: util.isSameEntry?

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:299:
* @param {Entry} entry Image entry.
FileEntry?

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:478:
* @param {Entry} entry The image entry.
FileEntry?

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:491:
} else if (FileType.getMediaType(entry) == 'image') {
=== is preferred.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:505:
* Rename the current image.
Renames

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:507:
* @param {Entry} newEntry The new image Entry.
FileEntry?

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:516:
* Unload content.
Unloads

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:817:
if (entry.toURL() in this.map_) {
Can we save the entry directory into the this.map_ and this.order_?

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:138: if
(this.selectedEntry_.filesystem.root.toURL() ===
Could you compare volume info instead of root URL?

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:287: for
(var i = 0; i != selectedEntries.length; i++) {
!== is preferred.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:302: for
(var i = 0; i != selectedEntries.length; i++) {
ditto.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:303: if
(FileType.getMediaType(selectedEntries[i]) == 'image')
ditto.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:492:
entry.remove(deleteNext, function() {
Could you add the TODO comment?
TODO(hirono): Use fileOperationManager.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:707: var e
= new Event('content');
Please replace e with event.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:10: *
@param {Entry} entry Image entry.
FileEntry

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:19: *
@return {Entry} Image entry.
FileEntry

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:966: var
e = new Event('content');
Please replace e with event.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:982: if
(oldEntry.toURL() != item.getEntry().toURL()) {
Use util.isSameEntry.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:1004: if
(newEntry.toURL() != event.oldEntry.toURL()) {
ditto.

[mtomasz, 2013-12-10 02:37:34]

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/directory_model.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/directory_model.js:942: *
@param {Array.<string>} entries Array of URLs.
On 2013/12/09 06:53:50, hirono wrote:
> nit: Please fix the comment.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/directory_model.js:951: if
(urls.indexOf(fileList.item(i).toURL()) >= 0)
On 2013/12/09 06:53:50, hirono wrote:
> 1. Is it also needed to select child entries?
> 
> 2. How about the following case?
> url: http://xxx/drive/root/ABC
> listItem: http://xxx/drive/root/A
> 

I don't think so. This code just checks if the url is in the urls array.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:674: //
TODO(mtomasz): Pass entries instead.
On 2013/12/09 06:53:50, hirono wrote:
> nit: The TODO has already done!

Yay! Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js:560:
return this.isBusy() && (this.entry_.toURL() == entry.toURL());
On 2013/12/09 06:53:50, hirono wrote:
> nit: util.isSameEntry?

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js:560:
return this.isBusy() && (this.entry_.toURL() == entry.toURL());
On 2013/12/09 06:53:50, hirono wrote:
> nit: util.isSameEntry?

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:299:
* @param {Entry} entry Image entry.
On 2013/12/09 06:53:50, hirono wrote:
> FileEntry?

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:478:
* @param {Entry} entry The image entry.
On 2013/12/09 06:53:50, hirono wrote:
> FileEntry?

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:491:
} else if (FileType.getMediaType(entry) == 'image') {
On 2013/12/09 06:53:50, hirono wrote:
> === is preferred.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:505:
* Rename the current image.
On 2013/12/09 06:53:50, hirono wrote:
> Renames

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:507:
* @param {Entry} newEntry The new image Entry.
On 2013/12/09 06:53:50, hirono wrote:
> FileEntry?

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:516:
* Unload content.
On 2013/12/09 06:53:50, hirono wrote:
> Unloads

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:817:
if (entry.toURL() in this.map_) {
On 2013/12/09 06:53:50, hirono wrote:
> Can we save the entry directory into the this.map_ and this.order_?

AFAIR objects as keys are not supported.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:138: if
(this.selectedEntry_.filesystem.root.toURL() ===
On 2013/12/09 06:53:50, hirono wrote:
> Could you compare volume info instead of root URL?

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:287: for
(var i = 0; i != selectedEntries.length; i++) {
On 2013/12/09 06:53:50, hirono wrote:
> !== is preferred.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:302: for
(var i = 0; i != selectedEntries.length; i++) {
On 2013/12/09 06:53:50, hirono wrote:
> ditto.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:303: if
(FileType.getMediaType(selectedEntries[i]) == 'image')
On 2013/12/09 06:53:50, hirono wrote:
> ditto.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:492:
entry.remove(deleteNext, function() {
On 2013/12/09 06:53:50, hirono wrote:
> Could you add the TODO comment?
> TODO(hirono): Use fileOperationManager.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:707: var e
= new Event('content');
On 2013/12/09 06:53:50, hirono wrote:
> Please replace e with event.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:10: *
@param {Entry} entry Image entry.
On 2013/12/09 06:53:50, hirono wrote:
> FileEntry

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:19: *
@return {Entry} Image entry.
On 2013/12/09 06:53:50, hirono wrote:
> FileEntry

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js
(right):

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:966: var
e = new Event('content');
On 2013/12/09 06:53:50, hirono wrote:
> Please replace e with event.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:982: if
(oldEntry.toURL() != item.getEntry().toURL()) {
On 2013/12/09 06:53:50, hirono wrote:
> Use util.isSameEntry.

Done.

https://codereview.chromium.org/109973002/diff/20001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:1004: if
(newEntry.toURL() != event.oldEntry.toURL()) {
On 2013/12/09 06:53:50, hirono wrote:
> ditto.

Done.

[hirono, 2013-12-10 03:36:53]

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/background/js/volume_manager.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/background/js/volume_manager.js:492:
e.volumeType = volumeInfo.volumeType;
Please remove this property. We can get volumeType from volumeInfo.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:687: context,
fm.volumeManager_, allEntries, entries);
FileManager have a public 'volumeManager' getter.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_util.js:634:
if (this.entry_.toURL().substr(0, 5) != 'data:') {  // Ignore data urls.
!== is preferred

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:328:
var loadingVideo = FileType.getMediaType(entry) == 'video';
=== is preferred.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:809:
if ((pos >= 0) != (entry.toURL() in this.map_))
!== is preferred

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:835:
if (this.order_.length == this.capacity_) {
=== is preferred

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:848:
if (oldEntry.toURL() == newEntry.toURL())
Please use util.isSameEntry.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:274: * Load
the content.
Loads

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:289: var
selectedIndex = entries.indexOf(selectedEntries[i]);
Can we use indexOf to compare Entries?
If it is precondition of the function, please add a comment.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:204:
if (name == this.entry_.name)
=== is preferred.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:217:
parentDir.getFile(fileName, {create: false, exclusive: false}, onExists,
Please place each argument per line.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:119:
(typeof value != 'string' || value === 'true');
!== is preferred.

[mtomasz, 2013-12-10 05:07:00]

Thanks!

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/background/js/volume_manager.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/background/js/volume_manager.js:492:
e.volumeType = volumeInfo.volumeType;
On 2013/12/10 03:36:53, hirono wrote:
> Please remove this property. We can get volumeType from volumeInfo.

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:687: context,
fm.volumeManager_, allEntries, entries);
On 2013/12/10 03:36:53, hirono wrote:
> FileManager have a public 'volumeManager' getter.

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:809:
if ((pos >= 0) != (entry.toURL() in this.map_))
On 2013/12/10 03:36:53, hirono wrote:
> !== is preferred

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:835:
if (this.order_.length == this.capacity_) {
On 2013/12/10 03:36:53, hirono wrote:
> === is preferred

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/image_editor/image_view.js:848:
if (oldEntry.toURL() == newEntry.toURL())
On 2013/12/10 03:36:53, hirono wrote:
> Please use util.isSameEntry.

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:274: * Load
the content.
On 2013/12/10 03:36:53, hirono wrote:
> Loads

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery.js:289: var
selectedIndex = entries.indexOf(selectedEntries[i]);
On 2013/12/10 03:36:53, hirono wrote:
> Can we use indexOf to compare Entries?
> If it is precondition of the function, please add a comment.

Added a comment. Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:204:
if (name == this.entry_.name)
On 2013/12/10 03:36:53, hirono wrote:
> === is preferred.

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/gallery_item.js:217:
parentDir.getFile(fileName, {create: false, exclusive: false}, onExists,
On 2013/12/10 03:36:53, hirono wrote:
> Please place each argument per line.

Done.

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js
(right):

https://codereview.chromium.org/109973002/diff/40001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/photo/slide_mode.js:119:
(typeof value != 'string' || value === 'true');
On 2013/12/10 03:36:53, hirono wrote:
> !== is preferred.

Done.

[hirono, 2013-12-10 08:49:30]

lgtm with nits! Thanks!

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/background/js/volume_manager.js
(right):

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/background/js/volume_manager.js:491:
e.volumeInfo = volumeInfo;
Sorry for less explanation. e.volumeType is used in the
VolumeManagerWrapper#onEvent.
So please re-write the method also.

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:633:
fm.directoryModel_.selectEntries(selectedEntries);
We cab also use directoryModel accessor.

[mtomasz, 2013-12-11 05:30:24]

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/background/js/volume_manager.js
(right):

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/background/js/volume_manager.js:491:
e.volumeInfo = volumeInfo;
On 2013/12/10 08:49:31, hirono wrote:
> Sorry for less explanation. e.volumeType is used in the
> VolumeManagerWrapper#onEvent.
> So please re-write the method also.

Done.

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/background/js/volume_manager.js:491:
e.volumeInfo = volumeInfo;
On 2013/12/10 08:49:31, hirono wrote:
> Sorry for less explanation. e.volumeType is used in the
> VolumeManagerWrapper#onEvent.
> So please re-write the method also.

Done.

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/109973002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:633:
fm.directoryModel_.selectEntries(selectedEntries);
On 2013/12/10 08:49:31, hirono wrote:
> We cab also use directoryModel accessor.

Done.

[commit-bot: I haz the power, 2013-12-11 05:31:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/109973002/80001

[commit-bot: I haz the power, 2013-12-11 12:15:37]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-11 12:18:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/109973002/80001

[commit-bot: I haz the power, 2013-12-11 13:26:31]

Change committed as 240098