Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: Source/core/dom/shadow/ShadowRoot.idl

Issue 1099723004: Sync the ShadowRoot interface with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: round 2 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/shadow/ShadowRoot.idl
diff --git a/Source/core/dom/shadow/ShadowRoot.idl b/Source/core/dom/shadow/ShadowRoot.idl
index 5a80d398e599a74a99b13c2646833447173596fe..fb18c29aa8174d7952bed2d546c4d1a2d97275c7 100644
--- a/Source/core/dom/shadow/ShadowRoot.idl
+++ b/Source/core/dom/shadow/ShadowRoot.idl
@@ -24,20 +24,22 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-interface ShadowRoot : DocumentFragment {
- readonly attribute Element activeElement;
-
- [ImplementedAs=olderShadowRootForBindings] readonly attribute ShadowRoot olderShadowRoot;
+// https://w3c.github.io/webcomponents/spec/shadow/#the-shadowroot-interface
+interface ShadowRoot : DocumentFragment {
+ Selection? getSelection();
+ // TODO(philipj): The x and y arguments should be of type double.
+ Element? elementFromPoint(long x, long y);
+ sequence<Element> elementsFromPoint(long x, long y);
+ readonly attribute Element? activeElement;
+ readonly attribute Element host;
+ [ImplementedAs=olderShadowRootForBindings] readonly attribute ShadowRoot? olderShadowRoot;
[TreatNullAs=NullString, CustomElementCallbacks, RaisesException=Setter] attribute DOMString innerHTML;
+ readonly attribute StyleSheetList styleSheets;
+ // TODO(philipj): The spec does not override cloneNode() on the ShadowRoot
+ // interface. Here, it's used to implement "Invoking the cloneNode() method
+ // on a ShadowRoot instance must always throw a DATA_CLONE_ERR exception" as
+ // Node.cloneNode() does not have [RaisesException].
[RaisesException] Node cloneNode([Default=Undefined] optional boolean deep);
- Selection getSelection();
-
- Element elementFromPoint(long x, long y);
-
- Element[] elementsFromPoint(long x, long y);
-
- readonly attribute StyleSheetList styleSheets;
- readonly attribute Element host;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698