Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1099713005: ozone: Add sync flag for atomic commit (Closed)

Created:
5 years, 8 months ago by achaulk
Modified:
5 years, 7 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Add sync flag for atomic commit and page flip event handling Committed: https://crrev.com/f7553583492a8ea9a54d75cd6b2d3dd83c94512c Cr-Commit-Position: refs/heads/master@{#326863} Committed: https://crrev.com/d6f9a4e6ed27e57f91bb0ddcf30a2cc96ddb198d Cr-Commit-Position: refs/heads/master@{#329919}

Patch Set 1 #

Total comments: 3

Patch Set 2 : true -> is_sync #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M ui/ozone/platform/drm/gpu/drm_device.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 2 1 chunk +15 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
achaulk
5 years, 8 months ago (2015-04-24 19:44:10 UTC) #2
dnicoara
https://codereview.chromium.org/1099713005/diff/1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc File ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc (right): https://codereview.chromium.org/1099713005/diff/1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc#newcode44 ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc:44: if (!drm_->CommitProperties(plane_list->atomic_property_set.get(), 0, true, Shouldn't we set this to ...
5 years, 8 months ago (2015-04-24 19:47:49 UTC) #3
achaulk
https://codereview.chromium.org/1099713005/diff/1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc File ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc (right): https://codereview.chromium.org/1099713005/diff/1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc#newcode44 ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc:44: if (!drm_->CommitProperties(plane_list->atomic_property_set.get(), 0, true, On 2015/04/24 19:47:49, dnicoara wrote: ...
5 years, 8 months ago (2015-04-24 19:50:41 UTC) #4
dnicoara
lgtm https://codereview.chromium.org/1099713005/diff/1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc File ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc (right): https://codereview.chromium.org/1099713005/diff/1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc#newcode44 ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc:44: if (!drm_->CommitProperties(plane_list->atomic_property_set.get(), 0, true, On 2015/04/24 19:50:41, achaulk ...
5 years, 8 months ago (2015-04-24 19:51:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099713005/20001
5 years, 8 months ago (2015-04-24 19:52:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 20:14:45 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f7553583492a8ea9a54d75cd6b2d3dd83c94512c Cr-Commit-Position: refs/heads/master@{#326863}
5 years, 8 months ago (2015-04-24 20:15:48 UTC) #9
Nikita (slow)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1098093005/ by nkostylev@chromium.org. ...
5 years, 8 months ago (2015-04-27 08:52:27 UTC) #10
achaulk
PTAL at rebase
5 years, 7 months ago (2015-05-14 19:55:17 UTC) #11
dnicoara
Still lgtm
5 years, 7 months ago (2015-05-14 19:58:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099713005/40001
5 years, 7 months ago (2015-05-14 20:00:21 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-14 20:26:43 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 20:27:45 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d6f9a4e6ed27e57f91bb0ddcf30a2cc96ddb198d
Cr-Commit-Position: refs/heads/master@{#329919}

Powered by Google App Engine
This is Rietveld 408576698