Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1099713004: Register existing chrome junit tests in GN (Closed)

Created:
5 years, 8 months ago by dgn
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register existing chrome junit tests in GN On GYP builds, chrome_junit_tests was building and running tests for media.remote, but GN builds didn't do that. This patch does the manual addition required for it with GN BUG=472067 Committed: https://crrev.com/5d8fd2c204e51799c26bb468aba4644b65a090b7 Cr-Commit-Position: refs/heads/master@{#326816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgn
PTAL. It just adds some test files and a required dependency to GN
5 years, 8 months ago (2015-04-24 15:51:15 UTC) #2
Bernhard Bauer
Nice, LGTM!
5 years, 8 months ago (2015-04-24 15:55:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099713004/1
5 years, 8 months ago (2015-04-24 15:57:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 16:26:43 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 16:27:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d8fd2c204e51799c26bb468aba4644b65a090b7
Cr-Commit-Position: refs/heads/master@{#326816}

Powered by Google App Engine
This is Rietveld 408576698