Issue 1099713003: Turn isEmpty check in parseSimpleTransform into ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1099713003: Turn isEmpty check in parseSimpleTransform into ASSERT (Closed)

Created:
5 years, 8 months ago by rwlbuis

Modified:
5 years, 8 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Turn isEmpty check in parseSimpleTransform into ASSERT Like the other parser helper methods, there is no need to check for isEmpty here, just ASSERT since it should never happen. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194470

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/css/parser/CSSParserFastPaths.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Timothy Loh

On 2015/04/24 21:58:22, rwlbuis wrote: > PTAL. Just a consistency thingie. lgtm

5 years, 8 months ago (2015-04-26 23:19:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099713003/20001

5 years, 8 months ago (2015-04-26 23:58:51 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 01:27:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194470