Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1099633002: Revert of Fix logic for doing incremental marking steps on tenured allocation. (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix logic for doing incremental marking steps on tenured allocation. (patchset #4 id:60001 of https://codereview.chromium.org/1040233003/) Reason for revert: Suspected of triggering memory corruption issues, e.g. crbug.com/478401. Original issue's description: > Fix logic for doing incremental marking steps on tenured allocation. > > R=hpayer@chromium.org > BUG= > > Committed: https://crrev.com/9716468ae63500adb74f5188c47de847e195d71b > Cr-Commit-Position: refs/heads/master@{#27883} TBR=hpayer@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c12e8d889c282e9a8d1b63e616dbbdc976995f4d Cr-Commit-Position: refs/heads/master@{#27944}

Patch Set 1 #

Patch Set 2 : manual revert based on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -59 lines) Patch
M src/heap/incremental-marking.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 1 6 chunks +15 lines, -49 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
Created Revert of Fix logic for doing incremental marking steps on tenured allocation.
5 years, 8 months ago (2015-04-20 15:07:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099633002/1
5 years, 8 months ago (2015-04-20 15:09:48 UTC) #3
commit-bot: I haz the power
Failed to apply patch for src/heap/incremental-marking.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-20 15:10:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099633002/130001
5 years, 8 months ago (2015-04-20 15:19:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:130001)
5 years, 8 months ago (2015-04-20 15:19:47 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 15:19:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c12e8d889c282e9a8d1b63e616dbbdc976995f4d
Cr-Commit-Position: refs/heads/master@{#27944}

Powered by Google App Engine
This is Rietveld 408576698