Source/core/xml/XPathValue.cpp - Issue 1099613003: Oilpan: have xml/ objects on the heap by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathValue.cpp

Issue 1099613003: Oilpan: have xml/ objects on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: simplify XPathResult dtor Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XPathValue.cpp

diff --git a/Source/core/xml/XPathValue.cpp b/Source/core/xml/XPathValue.cpp

index e8fe9e270d22cccfe245a14b894ae5edffaf7217..e74fe2f523feb2f9a5f541d62f0f4bd2f4923d6f 100644

--- a/Source/core/xml/XPathValue.cpp

+++ b/Source/core/xml/XPathValue.cpp

@@ -54,7 +54,7 @@ const NodeSet& Value::toNodeSet(EvaluationContext* context) const

context->hadTypeConversionError = true;

if (!m_data) {

- DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<NodeSet>, emptyNodeSet, (NodeSet::create()));

+ DEFINE_STATIC_LOCAL(Persistent<NodeSet>, emptyNodeSet, (NodeSet::create()));

return *emptyNodeSet;

}

« no previous file with comments | « Source/core/xml/XPathValue.h ('k') | Source/core/xml/XSLImportRule.h » ('j') | no next file with comments »