Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: Source/core/xml/XPathStep.h

Issue 1099613003: Oilpan: have xml/ objects on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: simplify XPathResult dtor Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XPathResult.idl ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathStep.h
diff --git a/Source/core/xml/XPathStep.h b/Source/core/xml/XPathStep.h
index 71056a1d048e3316ae9ab55e1df39f4fe3b1a308..8aceda0182dc6753321113e745d660c20f8b87e8 100644
--- a/Source/core/xml/XPathStep.h
+++ b/Source/core/xml/XPathStep.h
@@ -40,7 +40,6 @@ class Predicate;
class Step final : public ParseNode {
WTF_MAKE_NONCOPYABLE(Step);
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(Step);
public:
enum Axis {
AncestorAxis, AncestorOrSelfAxis, AttributeAxis,
@@ -50,8 +49,7 @@ public:
SelfAxis
};
- class NodeTest : public NoBaseWillBeGarbageCollectedFinalized<NodeTest> {
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(NodeTest);
+ class NodeTest : public GarbageCollectedFinalized<NodeTest> {
public:
enum Kind {
TextNodeTest, CommentNodeTest, ProcessingInstructionNodeTest, AnyNodeTest, NameTest
@@ -81,8 +79,8 @@ public:
Kind kind() const { return m_kind; }
const AtomicString& data() const { return m_data; }
const AtomicString& namespaceURI() const { return m_namespaceURI; }
- WillBeHeapVector<OwnPtrWillBeMember<Predicate>>& mergedPredicates() { return m_mergedPredicates; }
- const WillBeHeapVector<OwnPtrWillBeMember<Predicate>>& mergedPredicates() const { return m_mergedPredicates; }
+ HeapVector<Member<Predicate>>& mergedPredicates() { return m_mergedPredicates; }
+ const HeapVector<Member<Predicate>>& mergedPredicates() const { return m_mergedPredicates; }
private:
Kind m_kind;
@@ -90,11 +88,11 @@ public:
AtomicString m_namespaceURI;
// When possible, we merge some or all predicates with node test for better performance.
- WillBeHeapVector<OwnPtrWillBeMember<Predicate>> m_mergedPredicates;
+ HeapVector<Member<Predicate>> m_mergedPredicates;
};
Step(Axis, const NodeTest&);
- Step(Axis, const NodeTest&, WillBeHeapVector<OwnPtrWillBeMember<Predicate>>&);
+ Step(Axis, const NodeTest&, HeapVector<Member<Predicate>>&);
virtual ~Step();
DECLARE_VIRTUAL_TRACE();
@@ -106,7 +104,7 @@ public:
const NodeTest& nodeTest() const { return *m_nodeTest; }
private:
- friend void optimizeStepPair(Step*, Step*, bool&);
+ friend bool optimizeStepPair(Step*, Step*);
bool predicatesAreContextListInsensitive() const;
NodeTest& nodeTest() { return *m_nodeTest; }
@@ -115,11 +113,11 @@ private:
String namespaceFromNodetest(const String& nodeTest) const;
Axis m_axis;
- OwnPtrWillBeMember<NodeTest> m_nodeTest;
- WillBeHeapVector<OwnPtrWillBeMember<Predicate>> m_predicates;
+ Member<NodeTest> m_nodeTest;
+ HeapVector<Member<Predicate>> m_predicates;
};
-void optimizeStepPair(Step*, Step*, bool& dropSecondStep);
+bool optimizeStepPair(Step*, Step*);
} // namespace XPath
« no previous file with comments | « Source/core/xml/XPathResult.idl ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698