Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2034)

Unified Diff: Source/core/xml/XPathNodeSet.h

Issue 1099613003: Oilpan: have xml/ objects on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: simplify XPathResult dtor Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XPathNSResolver.idl ('k') | Source/core/xml/XPathNodeSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathNodeSet.h
diff --git a/Source/core/xml/XPathNodeSet.h b/Source/core/xml/XPathNodeSet.h
index d3cef85d7c99c435675fb724e7c732d866ac144b..e047c11e227f799ade4cec8c0c648e2b49a4edb9 100644
--- a/Source/core/xml/XPathNodeSet.h
+++ b/Source/core/xml/XPathNodeSet.h
@@ -34,11 +34,11 @@ namespace blink {
namespace XPath {
-class NodeSet : public NoBaseWillBeGarbageCollected<NodeSet> {
- WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(NodeSet);
+// TODO(Oilpan): drop Finalized once Node is on the heap.
+class NodeSet final : public GarbageCollectedFinalized<NodeSet> {
public:
- static PassOwnPtrWillBeRawPtr<NodeSet> create() { return adoptPtrWillBeNoop(new NodeSet); }
- static PassOwnPtrWillBeRawPtr<NodeSet> create(const NodeSet&);
+ static NodeSet* create() { return new NodeSet; }
+ static NodeSet* create(const NodeSet&);
DEFINE_INLINE_TRACE() { visitor->trace(m_nodes); }
size_t size() const { return m_nodes.size(); }
« no previous file with comments | « Source/core/xml/XPathNSResolver.idl ('k') | Source/core/xml/XPathNodeSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698