Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: Source/core/xml/XPathEvaluator.cpp

Issue 1099613003: Oilpan: have xml/ objects on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: simplify XPathResult dtor Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XPathEvaluator.h ('k') | Source/core/xml/XPathEvaluator.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathEvaluator.cpp
diff --git a/Source/core/xml/XPathEvaluator.cpp b/Source/core/xml/XPathEvaluator.cpp
index 21a49b85833f9fd820638fd87c9d077191163902..529e9e304be6b0647463228791770db0d11e34c7 100644
--- a/Source/core/xml/XPathEvaluator.cpp
+++ b/Source/core/xml/XPathEvaluator.cpp
@@ -39,29 +39,28 @@ namespace blink {
using namespace XPath;
-PassRefPtrWillBeRawPtr<XPathExpression> XPathEvaluator::createExpression(const String& expression, PassRefPtrWillBeRawPtr<XPathNSResolver> resolver, ExceptionState& exceptionState)
+XPathExpression* XPathEvaluator::createExpression(const String& expression, XPathNSResolver* resolver, ExceptionState& exceptionState)
{
return XPathExpression::createExpression(expression, resolver, exceptionState);
}
-PassRefPtrWillBeRawPtr<XPathNSResolver> XPathEvaluator::createNSResolver(Node* nodeResolver)
+XPathNSResolver* XPathEvaluator::createNSResolver(Node* nodeResolver)
{
return NativeXPathNSResolver::create(nodeResolver);
}
-PassRefPtrWillBeRawPtr<XPathResult> XPathEvaluator::evaluate(const String& expression, Node* contextNode,
- PassRefPtrWillBeRawPtr<XPathNSResolver> resolver, unsigned short type, const ScriptValue&, ExceptionState& exceptionState)
+XPathResult* XPathEvaluator::evaluate(const String& expression, Node* contextNode, XPathNSResolver* resolver, unsigned short type, const ScriptValue&, ExceptionState& exceptionState)
{
if (!isValidContextNode(contextNode)) {
exceptionState.throwDOMException(NotSupportedError, "The node provided is '" + contextNode->nodeName() + "', which is not a valid context node type.");
return nullptr;
}
- RefPtrWillBeRawPtr<XPathExpression> expr = createExpression(expression, resolver, exceptionState);
+ XPathExpression* expr = createExpression(expression, resolver, exceptionState);
if (exceptionState.hadException())
return nullptr;
return expr->evaluate(contextNode, type, ScriptValue(), exceptionState);
}
-}
+} // namespace blink
« no previous file with comments | « Source/core/xml/XPathEvaluator.h ('k') | Source/core/xml/XPathEvaluator.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698