Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: Source/core/xml/DocumentXPathEvaluator.h

Issue 1099613003: Oilpan: have xml/ objects on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: simplify XPathResult dtor Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/DOMParser.idl ('k') | Source/core/xml/DocumentXPathEvaluator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/DocumentXPathEvaluator.h
diff --git a/Source/core/xml/DocumentXPathEvaluator.h b/Source/core/xml/DocumentXPathEvaluator.h
index 978ef07064b016ffb24e0c86ba280d5d094ab5fb..85ed92027a7ae495692b845d5d7ab1b22e200c7b 100644
--- a/Source/core/xml/DocumentXPathEvaluator.h
+++ b/Source/core/xml/DocumentXPathEvaluator.h
@@ -41,11 +41,11 @@ class DocumentXPathEvaluator final : public NoBaseWillBeGarbageCollected<Documen
public:
static DocumentXPathEvaluator& from(WillBeHeapSupplementable<Document>&);
- static PassRefPtrWillBeRawPtr<XPathExpression> createExpression(WillBeHeapSupplementable<Document>&,
- const String& expression, PassRefPtrWillBeRawPtr<XPathNSResolver>, ExceptionState&);
- static PassRefPtrWillBeRawPtr<XPathNSResolver> createNSResolver(WillBeHeapSupplementable<Document>&, Node* nodeResolver);
- static PassRefPtrWillBeRawPtr<XPathResult> evaluate(WillBeHeapSupplementable<Document>&,
- const String& expression, Node* contextNode, PassRefPtrWillBeRawPtr<XPathNSResolver>,
+ static XPathExpression* createExpression(WillBeHeapSupplementable<Document>&,
+ const String& expression, XPathNSResolver*, ExceptionState&);
+ static XPathNSResolver* createNSResolver(WillBeHeapSupplementable<Document>&, Node* nodeResolver);
+ static XPathResult* evaluate(WillBeHeapSupplementable<Document>&,
+ const String& expression, Node* contextNode, XPathNSResolver*,
unsigned short type, const ScriptValue&, ExceptionState&);
DECLARE_VIRTUAL_TRACE();
@@ -55,7 +55,7 @@ private:
static const char* supplementName() { return "DocumentXPathEvaluator"; }
- RefPtrWillBeMember<XPathEvaluator> m_xpathEvaluator;
+ PersistentWillBeMember<XPathEvaluator> m_xpathEvaluator;
};
} // namespace blink
« no previous file with comments | « Source/core/xml/DOMParser.idl ('k') | Source/core/xml/DocumentXPathEvaluator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698