Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: Source/core/xml/DOMParser.h

Issue 1099613003: Oilpan: have xml/ objects on the heap by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: simplify XPathResult dtor Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/xml/DOMParser.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/DOMParser.h
diff --git a/Source/core/xml/DOMParser.h b/Source/core/xml/DOMParser.h
index 07d14a588e143da37182f53dc04728c2b0cd60a7..34074da7f2e5361d6b0aa26984509e98063c8f45 100644
--- a/Source/core/xml/DOMParser.h
+++ b/Source/core/xml/DOMParser.h
@@ -22,19 +22,17 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
-#include "wtf/RefCounted.h"
-#include "wtf/RefPtr.h"
namespace blink {
class Document;
-class DOMParser final : public RefCountedWillBeGarbageCollected<DOMParser>, public ScriptWrappable {
+class DOMParser final : public GarbageCollectedFinalized<DOMParser>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static PassRefPtrWillBeRawPtr<DOMParser> create(Document& document)
+ static DOMParser* create(Document& document)
{
- return adoptRefWillBeNoop(new DOMParser(document));
+ return new DOMParser(document);
}
PassRefPtrWillBeRawPtr<Document> parseFromString(const String&, const String& type);
@@ -42,7 +40,7 @@ public:
DECLARE_TRACE();
private:
- DOMParser(Document&);
+ explicit DOMParser(Document&);
WeakPtrWillBeWeakMember<Document> m_contextDocument;
};
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/xml/DOMParser.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698