Oilpan: have xml/ objects on the heap by default.

Source/core/xml/XPathParser.h

 /*
  * Copyright 2005 Maksim Orlovich <maksim@kde.org>
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 49 matching lines @@
 class Parser {
     WTF_MAKE_NONCOPYABLE(Parser);
     STACK_ALLOCATED();
 public:
     Parser();
     ~Parser();
 
     XPathNSResolver* resolver() const { return m_resolver.get(); }
     bool expandQName(const String& qName, AtomicString& localName, AtomicString& namespaceURI);
 
-    PassOwnPtrWillBeRawPtr<Expression> parseStatement(const String& statement, PassRefPtrWillBeRawPtr<XPathNSResolver>, ExceptionState&);
+    Expression* parseStatement(const String& statement, XPathNSResolver*, ExceptionState&);
 
     static Parser* current() { return currentParser; }
 
     int lex(void* yylval);
 
-    RawPtrWillBeMember<Expression> m_topExpr;
+    Member<Expression> m_topExpr;
     bool m_gotNamespaceError;
 
-    void registerParseNode(ParseNode*);
-    void unregisterParseNode(ParseNode*);
-
-    void registerPredicateVector(WillBeHeapVector<OwnPtrWillBeMember<Predicate>>*);
-    void deletePredicateVector(WillBeHeapVector<OwnPtrWillBeMember<Predicate>>*);
-
-    void registerExpressionVector(WillBeHeapVector<OwnPtrWillBeMember<Expression>>*);
-    void deleteExpressionVector(WillBeHeapVector<OwnPtrWillBeMember<Expression>>*);
-
     void registerString(String*);
     void deleteString(String*);
 
-    void registerNodeTest(Step::NodeTest*);
-    void deleteNodeTest(Step::NodeTest*);

[haraken, 2015/04/26 15:36:23]

Nit: You could explain these removals in the CL description.

[sof, 2015/04/26 15:41:26]

Will do, the switch to Oilpan allows letting go of the register&delete machinery
the parser previously depended on.

-
 private:
     bool isBinaryOperatorContext() const;
 
     void skipWS();
     Token makeTokenAndAdvance(int type, int advance = 1);
     Token makeTokenAndAdvance(int type, NumericOp::Opcode, int advance = 1);
     Token makeTokenAndAdvance(int type, EqTestOp::Opcode, int advance = 1);
     char peekAheadHelper();
     char peekCurHelper();
 
     Token lexString();
     Token lexNumber();
     bool lexNCName(String&);
     bool lexQName(String&);
 
     Token nextToken();
     Token nextTokenInternal();
 
     void reset(const String& data);
 
     static Parser* currentParser;
 
     unsigned m_nextPos;
     String m_data;
     int m_lastTokenType;
-    RefPtrWillBeMember<XPathNSResolver> m_resolver;
+    Member<XPathNSResolver> m_resolver;
 
-#if !ENABLE(OILPAN)
-    HashSet<ParseNode*> m_parseNodes;
-    HashSet<Vector<OwnPtr<Predicate>>*> m_predicateVectors;
-    HashSet<Vector<OwnPtr<Expression>>*> m_expressionVectors;
-    HashSet<OwnPtr<Step::NodeTest>> m_nodeTests;
-#endif
     HashSet<OwnPtr<String>> m_strings;
 };
 
 } // namespace XPath
 
 } // namespace blink
 
 int xpathyyparse(blink::XPath::Parser*);
 #endif