Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: lib/compiler/implementation/js_backend/emitter.dart

Issue 10996062: Use static final empty Modifier instead of null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Missing uses fixed. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/js_backend/emitter.dart
diff --git a/lib/compiler/implementation/js_backend/emitter.dart b/lib/compiler/implementation/js_backend/emitter.dart
index 1e1d895d78071e136f761c319644acc306803184..d57a1ba9e05797e63d255d52c8dc4377a1566c4a 100644
--- a/lib/compiler/implementation/js_backend/emitter.dart
+++ b/lib/compiler/implementation/js_backend/emitter.dart
@@ -497,7 +497,7 @@ function(prototype, staticName, fieldName, getterName, lazyValue) {
bool instanceFieldNeedsSetter(Element member) {
assert(member.isField());
- return (member.modifiers === null || !member.modifiers.isFinalOrConst())
+ return (!member.modifiers.isFinalOrConst())
&& compiler.codegenWorld.hasInvokedSetter(member, compiler);
}
@@ -523,7 +523,7 @@ function(prototype, staticName, fieldName, getterName, lazyValue) {
|| member.isGenerativeConstructorBody()
|| member.isGetter()
|| member.isSetter()) {
- if (member.modifiers !== null && member.modifiers.isAbstract()) return;
+ if (member.modifiers.isAbstract()) return;
CodeBuffer codeBuffer = compiler.codegenWorld.generatedCode[member];
if (codeBuffer == null) return;
defineInstanceMember(namer.getName(member), codeBuffer);

Powered by Google App Engine
This is Rietveld 408576698