Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: ui/gfx/safe_floor_ceil.cc

Issue 10996037: Do not convert from RectF to Rect by flooring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/safe_floor_ceil.cc
diff --git a/ui/gfx/safe_floor_ceil.cc b/ui/gfx/safe_floor_ceil.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3932e482f60030a4002f771a8ea0e48e7adb6cef
--- /dev/null
+++ b/ui/gfx/safe_floor_ceil.cc
@@ -0,0 +1,29 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <cmath>
+#include <limits>
+
+namespace gfx {
+
+int ClampToInt(float value) {
sky 2012/09/27 20:33:55 Do we really need all this? Are we really passing
+ if (value != value)
+ return 0; // no int NaN.
+ if (value > std::numeric_limits<int>::max())
+ return std::numeric_limits<int>::max();
+ if (value < std::numeric_limits<int>::min())
+ return std::numeric_limits<int>::max();
+ return static_cast<int>(value);
+}
+
+int ToFlooredInt(float value) {
+ return ClampToInt(std::floor(value));
+}
+
+int ToCeiledInt(float value) {
+ return ClampToInt(std::ceil(value));
+}
+
+} // namespace gfx
+

Powered by Google App Engine
This is Rietveld 408576698