Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10996032: Merge 129370 - snapToSize rounds the incorrectly for negative locations (Closed)

Created:
8 years, 2 months ago by eae
Modified:
8 years, 2 months ago
Reviewers:
eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 129370 - snapToSize rounds the incorrectly for negative locations https://bugs.webkit.org/show_bug.cgi?id=97265 Reviewed by Eric Seidel. Source/WebCore: Change snapSizeToPixel to preserve sign for location which affects rounding. Test: fast/sub-pixel/snap-negative-location.html * platform/FractionalLayoutUnit.h: (WebCore::snapSizeToPixel): LayoutTests: Add test for snapSizeToPixel handling of negative locations. Skipped on platforms that do not enable subpixel layout. * fast/sub-pixel/snap-negative-location-expected.html: Added. * fast/sub-pixel/snap-negative-location.html: Added. * platform/mac-lion/Skipped: * platform/mac-snowleopard/Skipped: * platform/mac-wk2/Skipped: * platform/mac/Skipped: * platform/qt-4.8/Skipped: * platform/qt/Skipped: * platform/win-wk2/Skipped: * platform/win-xp/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: * platform/wk2/Skipped: TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A + LayoutTests/fast/sub-pixel/snap-negative-location.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/sub-pixel/snap-negative-location-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/mac-lion/Skipped View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/platform/mac-snowleopard/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac-wk2/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/qt-4.8/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win-wk2/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win-xp/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/wincairo/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/wk2/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/FractionalLayoutUnit.h View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eae
8 years, 2 months ago (2012-09-26 19:41:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698