Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 10996024: chrome: Remove tab_modal_confirm_dialog_views.h entry from DEPS whitelist. (Closed)

Created:
8 years, 2 months ago by tfarina
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

chrome: Remove tab_modal_confirm_dialog_views.h entry from DEPS whitelist. This dependency was fixed in a past review so it's to remove this now. BUG=125846 TBR=ben@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
TBRing...
8 years, 2 months ago (2012-09-26 20:58:09 UTC) #1
Ben Goodger (Google)
8 years, 2 months ago (2012-09-27 16:23:53 UTC) #2
lgtm


On Wed, Sep 26, 2012 at 1:58 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google), sky,
>
> Message:
> TBRing...
>
> Description:
> chrome: Remove tab_modal_confirm_dialog_**views.h entry from DEPS
> whitelist.
>
> This dependency was fixed in a past review so it's to remove this now.
>
> BUG=125846
> TBR=ben@chromium.org,sky@**chromium.org <sky@chromium.org>
>
>
> Please review this at
http://codereview.chromium.**org/10996024/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/DEPS
>
>
> Index: chrome/browser/ui/DEPS
> diff --git a/chrome/browser/ui/DEPS b/chrome/browser/ui/DEPS
> index c6df8764c57fc60229e790c9009eb0**8599222ab2..**
> 5889576b540ce5d43f4ef46d26850c**ce904dea10 100644
> --- a/chrome/browser/ui/DEPS
> +++ b/chrome/browser/ui/DEPS
> @@ -7,6 +7,5 @@ include_rules = [
>   "!chrome/browser/ui/views/sad_**tab_view.h",
>   "!chrome/browser/ui/views/tab_**icon_view.h",
>   "!chrome/browser/ui/views/tab_**icon_view_model.h",
> - "!chrome/browser/ui/views/tab_**modal_confirm_dialog_views.h",
>   # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!
>  ]
>
>
>

Powered by Google App Engine
This is Rietveld 408576698