Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1099553003: Added unit tests for getCredentialsFromAuthCode. (Closed)

Created:
5 years, 8 months ago by John Williams
Modified:
5 years, 8 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added unit tests for getCredentialsFromAuthCode. BUG=471928 Committed: https://crrev.com/8544c7042687e2ede68ee00ea6b599072cfc1768 Cr-Commit-Position: refs/heads/master@{#327144}

Patch Set 1 #

Total comments: 14

Patch Set 2 : for review #

Total comments: 7

Patch Set 3 : formatting fixes #

Patch Set 4 : sync to head #

Patch Set 5 : cl format #

Patch Set 6 : sync to head again #

Patch Set 7 : updated BUILD.gn file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -223 lines) Patch
M remoting/host/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A + remoting/host/setup/gaia_oauth_client.h View 1 2 3 2 chunks +20 lines, -26 lines 0 comments Download
A + remoting/host/setup/gaia_oauth_client.cc View 1 2 3 4 5 6 chunks +18 lines, -24 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 1 2 5 chunks +42 lines, -12 lines 0 comments Download
A remoting/host/setup/mock_oauth_client.h View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A remoting/host/setup/mock_oauth_client.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M remoting/host/setup/oauth_client.h View 1 2 3 3 chunks +9 lines, -53 lines 0 comments Download
D remoting/host/setup/oauth_client.cc View 1 2 3 4 5 1 chunk +0 lines, -106 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (14 generated)
John Williams
5 years, 8 months ago (2015-04-24 00:42:44 UTC) #2
Lambros
Tests look good, thanks for doing this! Just a code-layout tweak, and some nits. https://codereview.chromium.org/1099553003/diff/1/remoting/host/setup/mock_oauth_client.h ...
5 years, 8 months ago (2015-04-24 18:15:50 UTC) #3
John Williams
https://codereview.chromium.org/1099553003/diff/1/remoting/host/setup/mock_oauth_client.h File remoting/host/setup/mock_oauth_client.h (right): https://codereview.chromium.org/1099553003/diff/1/remoting/host/setup/mock_oauth_client.h#newcode5 remoting/host/setup/mock_oauth_client.h:5: #ifndef REMOTING_HOST_SETUP_MOCK_OAUTH_CLIENT On 2015/04/24 18:15:50, Lambros wrote: > nit: ...
5 years, 8 months ago (2015-04-24 21:05:14 UTC) #4
Lambros
lgtm with formatting nits. 'git cl format' should fix these for you :) https://codereview.chromium.org/1099553003/diff/20001/remoting/host/setup/gaia_oauth_client.cc File ...
5 years, 8 months ago (2015-04-24 21:38:56 UTC) #5
John Williams
https://codereview.chromium.org/1099553003/diff/20001/remoting/host/setup/gaia_oauth_client.cc File remoting/host/setup/gaia_oauth_client.cc (right): https://codereview.chromium.org/1099553003/diff/20001/remoting/host/setup/gaia_oauth_client.cc#newcode56 remoting/host/setup/gaia_oauth_client.cc:56: const std::string& user_email, On 2015/04/24 21:38:56, Lambros wrote: > ...
5 years, 8 months ago (2015-04-24 21:48:42 UTC) #6
Lambros
Those formatting changes all look fine to me. In general, I think we should accept ...
5 years, 8 months ago (2015-04-24 21:54:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099553003/40001
5 years, 8 months ago (2015-04-24 22:11:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/46491) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-24 22:19:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099553003/80001
5 years, 8 months ago (2015-04-25 00:12:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/65513)
5 years, 8 months ago (2015-04-25 00:29:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099553003/100001
5 years, 8 months ago (2015-04-25 00:45:27 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/65525) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 8 months ago (2015-04-25 02:30:14 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099553003/100001
5 years, 8 months ago (2015-04-25 17:11:00 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/65598)
5 years, 8 months ago (2015-04-25 17:21:32 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099553003/120001
5 years, 8 months ago (2015-04-27 20:02:56 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 8 months ago (2015-04-27 21:45:40 UTC) #30
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:49:51 UTC) #31
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/8544c7042687e2ede68ee00ea6b599072cfc1768
Cr-Commit-Position: refs/heads/master@{#327144}

Powered by Google App Engine
This is Rietveld 408576698