Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: extensions/common/event_filtering_info.h

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/event_filtering_info.h
diff --git a/extensions/common/event_filtering_info.h b/extensions/common/event_filtering_info.h
index a3587986a9ece864024876dab462af867538615a..f51e3d2b5fe3eb598eb7eae3d958e28adb7d919b 100644
--- a/extensions/common/event_filtering_info.h
+++ b/extensions/common/event_filtering_info.h
@@ -26,12 +26,20 @@ class EventFilteringInfo {
public:
EventFilteringInfo();
~EventFilteringInfo();
+ void SetWindowType(const std::string& window_type);
void SetURL(const GURL& url);
void SetInstanceID(int instance_id);
void SetServiceType(const std::string& service_type) {
service_type_ = service_type;
}
+ // Note: window type is a Chrome concept, so arguably doesn't belong
+ // in the extensions module. If the number of Chrome concept grows,
+ // consider a delegation model with a ChromeEventFilteringInfo
+ // class.
+ bool has_window_type() const { return has_window_type_; }
+ const std::string& window_type() const { return window_type_; }
+
bool has_url() const { return has_url_; }
const GURL& url() const { return url_; }
@@ -52,6 +60,9 @@ class EventFilteringInfo {
bool has_instance_id_;
int instance_id_;
+ bool has_window_type_;
+ std::string window_type_;
+
// Allow implicit copy and assignment.
};
« no previous file with comments | « chrome/test/data/extensions/api_test/windows/events/test.js ('k') | extensions/common/event_filtering_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698