chrome/browser/extensions/extension_tab_util.cc - Issue 1099553002: extensions: windows: list all windows from the current profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index 6ac0c78efe3740fb9ac52a4f370b64044abaaadd..384c94d02d22ec80fbcbd8b740115e7a2e445dc8 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -432,9 +432,10 @@ void ExtensionTabUtil::ScrubTabValueForExtension(

WebContents* contents,

const Extension* extension,

base::DictionaryValue* tab_info) {

- bool has_permission = extension &&

+ int tab_id = GetTabId(contents);

+ bool has_permission = tab_id >= 0 && extension &&

extension->permissions_data()->HasAPIPermissionForTab(

- GetTabId(contents), APIPermission::kTab);

+ tab_id, APIPermission::kTab);

if (!has_permission) {

tab_info->Remove(keys::kUrlKey, NULL);

« no previous file with comments | « chrome/browser/extensions/api/tabs/windows_util.cc ('k') | chrome/browser/extensions/window_controller.h » ('j') | no next file with comments »