Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2737)

Unified Diff: chrome/browser/extensions/api/tabs/windows_util.h

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move filters into window_controller.cc/h Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/windows_util.h
diff --git a/chrome/browser/extensions/api/tabs/windows_util.h b/chrome/browser/extensions/api/tabs/windows_util.h
index 0e0a8d2ff4a8bccc44e50e90379766500e65f8e5..be671bbc2632afbfb501f1e736d9cc99694319c8 100644
--- a/chrome/browser/extensions/api/tabs/windows_util.h
+++ b/chrome/browser/extensions/api/tabs/windows_util.h
@@ -5,24 +5,43 @@
#ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_WINDOWS_UTIL_H__
#define CHROME_BROWSER_EXTENSIONS_API_TABS_WINDOWS_UTIL_H__
+#include "chrome/browser/extensions/window_controller_list.h"
+#include "chrome/common/extensions/api/windows.h"
+
class UIThreadExtensionFunction;
+namespace content {
+class BrowserContext;
+}
+
namespace extensions {
+class Extension;
class WindowController;
}
namespace windows_util {
+// Converts an array of window types given by the chrome.windows APIs
+// to a WindowTypeFilter.
+extensions::WindowTypeFilter WindowTypeFilterFromWindowTypes(
+ const std::vector<extensions::api::windows::WindowType>& types);
+
// Populates |controller| for given |window_id|. If the window is not found,
// returns false and sets UIThreadExtensionFunction error_.
bool GetWindowFromWindowID(UIThreadExtensionFunction* function,
int window_id,
+ extensions::WindowTypeFilter filter,
extensions::WindowController** controller);
// Returns true if |function| (and the profile and extension that it was
// invoked from) can operate on the window wrapped by |window_controller|.
+// If |all_window_types| is set this function will return true for any
+// kind of window (including app and devtools), otherwise it will
+// return true only for normal browser windows as well as windows
+// created by the extension.
bool CanOperateOnWindow(const UIThreadExtensionFunction* function,
- const extensions::WindowController* controller);
+ const extensions::WindowController* controller,
+ extensions::WindowTypeFilter filter);
} // namespace windows_util

Powered by Google App Engine
This is Rietveld 408576698