chrome/common/extensions/permissions/permission_set_unittest.cc - Issue 1099553002: extensions: windows: list all windows from the current profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add application windows resize constraint test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/windows_event_router.h ('K') | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | extensions/common/manifest_handlers/permissions_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set_unittest.cc

diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc

index 006d00a2bcfb5cbaa57e9a98a9469465f99b82be..ddbe8ea08ba3bfd715879b1db60599dcd5d74b02 100644

--- a/chrome/common/extensions/permissions/permission_set_unittest.cc

+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc

@@ -139,6 +139,8 @@ TEST(PermissionsTest, GetByName) {

EXPECT_EQ(APIPermission::kTab, info->GetByName("tabs")->id());

EXPECT_EQ(APIPermission::kManagement,

info->GetByName("management")->id());

+ EXPECT_EQ(APIPermission::kWindowsGlobal,

+ info->GetByName("windows.global")->id());

EXPECT_FALSE(info->GetByName("alsdkfjasldkfj"));

}

@@ -748,6 +750,7 @@ TEST(PermissionsTest, PermissionMessages) {

skip.insert(APIPermission::kUnlimitedStorage);

skip.insert(APIPermission::kWebcamPrivate);

skip.insert(APIPermission::kWebView);

+ skip.insert(APIPermission::kWindowsGlobal);

skip.insert(APIPermission::kWindowShape);

// These permissions are restricted to extensions force-installed by policy