chrome/browser/extensions/api/tabs/windows_util.cc - Issue 1099553002: extensions: windows: list all windows from the current profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/windows_util.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add application windows resize constraint test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/windows_event_router.h ('K') | « chrome/browser/extensions/api/tabs/windows_event_router.cc ('k') | chrome/browser/ui/panels/panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/windows_util.cc

diff --git a/chrome/browser/extensions/api/tabs/windows_util.cc b/chrome/browser/extensions/api/tabs/windows_util.cc

index 48c6824f4775f9fb2448eae6bfa7d36ef245b762..16df97f94110b3fb4f3a160099e411c50326b2d1 100644

--- a/chrome/browser/extensions/api/tabs/windows_util.cc

+++ b/chrome/browser/extensions/api/tabs/windows_util.cc

@@ -38,6 +38,7 @@ bool GetWindowFromWindowID(ChromeUIThreadExtensionFunction* function,

} else {

*controller = extensions::WindowControllerList::GetInstance()

->FindWindowForFunctionById(function_details, window_id);

if (!(*controller)) {

function->SetError(extensions::ErrorUtils::FormatErrorMessage(

extensions::tabs_constants::kWindowNotFoundError,