chrome/browser/extensions/api/tabs/ash_panel_contents.cc - Issue 1099553002: extensions: windows: list all windows from the current profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/ash_panel_contents.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add application windows resize constraint test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/app_window_controller.cc ('K') | « chrome/browser/extensions/api/tabs/app_window_controller.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/ash_panel_contents.cc

diff --git a/chrome/browser/extensions/api/tabs/ash_panel_contents.cc b/chrome/browser/extensions/api/tabs/ash_panel_contents.cc

index 86286c36a56871e81433dacfa2b51d5fc30ae9fc..e5889ff35649ced7c4ebaf8b96b190623faf895d 100644

--- a/chrome/browser/extensions/api/tabs/ash_panel_contents.cc

+++ b/chrome/browser/extensions/api/tabs/ash_panel_contents.cc

@@ -18,6 +18,8 @@

#include "content/public/browser/web_contents.h"

#include "extensions/browser/app_window/native_app_window.h"

#include "extensions/common/extension.h"

+#include "extensions/common/permissions/api_permission.h"

+#include "extensions/common/permissions/permissions_data.h"

#include "ui/gfx/image/image.h"

using extensions::AppWindow;

@@ -139,6 +141,9 @@ void AshPanelWindowController::SetFullscreenMode(

bool AshPanelWindowController::IsVisibleToExtension(

const extensions::Extension* extension) const {

+ if (extension->permissions_data()->HasAPIPermission(

+ extensions::APIPermission::kWindowsGlobal))

+ return true;

return extension->id() == app_window_->extension_id();

}