chrome/common/extensions/permissions/permission_set_unittest.cc - Issue 1099553002: extensions: windows: list all windows from the current profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/permissions/chrome_api_permissions.cc ('K') | « chrome/common/extensions/permissions/chrome_permission_message_rules.cc ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set_unittest.cc

diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc

index f212652ab25e7d784d054d97d75e0a6000f27ea5..b089390c09b90629d0493b9e7b145eff9733ff11 100644

--- a/chrome/common/extensions/permissions/permission_set_unittest.cc

+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc

@@ -137,6 +137,7 @@ TEST(PermissionsTest, GetByID) {

TEST(PermissionsTest, GetByName) {

PermissionsInfo* info = PermissionsInfo::GetInstance();

EXPECT_EQ(APIPermission::kTab, info->GetByName("tabs")->id());

+ EXPECT_EQ(APIPermission::kTabGlobal, info->GetByName("tabs.global")->id());

EXPECT_EQ(APIPermission::kManagement,

info->GetByName("management")->id());

EXPECT_FALSE(info->GetByName("alsdkfjasldkfj"));

@@ -184,6 +185,8 @@ TEST(PermissionsTest, Aliases) {

EXPECT_EQ(tabs_name, info->GetByID(APIPermission::kTab)->name());

EXPECT_EQ(APIPermission::kTab, info->GetByName("tabs")->id());

EXPECT_EQ(APIPermission::kTab, info->GetByName("windows")->id());

+ EXPECT_EQ(APIPermission::kTabGlobal, info->GetByName("tabs.global")->id());

+ EXPECT_EQ(APIPermission::kTabGlobal, info->GetByName("windows.global")->id());

// unlimitedStorage: unlimitedStorage, unlimited_storage

std::string storage_name = "unlimitedStorage";