chrome/browser/ui/panels/panel.cc - Issue 1099553002: extensions: windows: list all windows from the current profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/ash_panel_contents.cc ('k') | chrome/common/extensions/permissions/chrome_api_permissions.cc » ('j') | chrome/common/extensions/permissions/chrome_api_permissions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel.cc

diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc

index 949c612a845b03667f95e7eda74920108d6feaf2..91f7ee0a87df6179d0e4826e0a798ca5ce4ed348 100644

--- a/chrome/browser/ui/panels/panel.cc

+++ b/chrome/browser/ui/panels/panel.cc

@@ -40,6 +40,8 @@

#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_handlers/icons_handler.h"

+#include "extensions/common/permissions/api_permission.h"

+#include "extensions/common/permissions/permissions_data.h"

#include "ui/gfx/geometry/rect.h"

#include "ui/gfx/image/image.h"

@@ -151,6 +153,9 @@ void PanelExtensionWindowController::SetFullscreenMode(

bool PanelExtensionWindowController::IsVisibleToExtension(

const extensions::Extension* extension) const {

+ if (extension->permissions_data()->HasAPIPermission(

Peter Kasting 2015/04/20 20:55:35 Nit: Shorter: return (extension->id() == panel_

+ extensions::APIPermission::kTabGlobal))

+ return true;

return extension->id() == panel_->extension_id();

}