extensions: windows: list all windows from the current profile

extensions/common/event_filtering_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_EVENT_FILTERING_INFO_H_
 #define EXTENSIONS_COMMON_EVENT_FILTERING_INFO_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "url/gurl.h"
 
 namespace base {
 class Value;
 }
 
 namespace extensions {
 
 // Extra information about an event that is used in event filtering.
 //
 // This is the information that is matched against criteria specified in JS
 // extension event listeners. Eg:
 //
 // chrome.someApi.onSomeEvent.addListener(cb,
 //                                        {url: [{hostSuffix: 'google.com'}],
 //                                         tabId: 1});
 class EventFilteringInfo {
  public:
   EventFilteringInfo();
   ~EventFilteringInfo();
+  void SetWindowType(const std::string& window_type);
   void SetURL(const GURL& url);
   void SetInstanceID(int instance_id);
   void SetServiceType(const std::string& service_type) {
     service_type_ = service_type;
   }
 
+  bool has_window_type() const { return has_window_type_; }

[not at google - send to devlin, 2015/07/31 21:48:03]

Could you add a comment:

Note: window type is a Chrome concept, so arguably doesn't belong in the
extensions module. If the number of Chrome concept grows, consider a delegation
model with a ChromeEventFilteringInfo class.

[llandwerlin-old, 2015/08/03 10:11:54]

Done.

+  const std::string& window_type() const { return window_type_; }
+
   bool has_url() const { return has_url_; }
   const GURL& url() const { return url_; }
 
   bool has_instance_id() const { return has_instance_id_; }
   int instance_id() const { return instance_id_; }
 
   bool has_service_type() const { return !service_type_.empty(); }
   const std::string& service_type() const { return service_type_; }
 
   scoped_ptr<base::Value> AsValue() const;
   bool IsEmpty() const;
 
  private:
   bool has_url_;
   GURL url_;
   std::string service_type_;
 
   bool has_instance_id_;
   int instance_id_;
 
+  bool has_window_type_;
+  std::string window_type_;
+
   // Allow implicit copy and assignment.
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_EVENT_FILTERING_INFO_H_