extensions: windows: list all windows from the current profile

chrome/browser/extensions/window_controller_list.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/window_controller_list.h"
 
 #include <algorithm>
 
 #include "chrome/browser/extensions/api/tabs/windows_util.h"
 #include "chrome/browser/extensions/chrome_extension_function_details.h"
@@ skipping 45 matching lines @@
 
 WindowController* WindowControllerList::FindWindowById(int id) const {
   for (ControllerList::const_iterator iter = windows().begin();
        iter != windows().end(); ++iter) {
     if ((*iter)->GetWindowId() == id)
       return *iter;
   }
   return NULL;
 }
 
+WindowController* WindowControllerList::FindWindowByIdWithFilter(
+    int id,
+    const WindowTypeFilter& filter) const {
+  for (ControllerList::const_iterator iter = windows().begin();
+       iter != windows().end(); ++iter) {
+    if ((*iter)->GetWindowId() == id &&
+        windows_util::WindowMatchesTypeFilter(*iter, filter))

[not at google - send to devlin, 2015/07/31 21:48:03]

To share code with this and FindWindowById, and once these filters are
especially cheap, I'd make FindWindowId directly call FindWindowByIdWithFilter
with a filter that matches everything.

Similar for other functions.

[llandwerlin-old, 2015/08/03 10:11:54]

Done.

+      return *iter;
+  }
+  return NULL;

[not at google - send to devlin, 2015/07/31 21:48:03]

NULL --> nullptr

[llandwerlin-old, 2015/08/03 10:11:54]

Done.

+}
+
 WindowController* WindowControllerList::FindWindowForFunctionById(
     const UIThreadExtensionFunction* function,
     int id) const {
-  WindowController* controller = FindWindowById(id);
-  if (controller && windows_util::CanOperateOnWindow(function, controller))
+  return FindWindowForFunctionByIdWithFilter(
+      function, id, windows_util::GetDefaultWindowTypeFilters());
+}
+
+WindowController* WindowControllerList::FindWindowForFunctionByIdWithFilter(
+    const UIThreadExtensionFunction* function,
+    int id,
+    const WindowTypeFilter& filter) const {
+  WindowController* controller = FindWindowByIdWithFilter(id, filter);
+  if (controller &&
+      windows_util::CanOperateOnWindow(function, controller, filter))
     return controller;
   return NULL;
 }
 
 WindowController* WindowControllerList::CurrentWindowForFunction(
     const UIThreadExtensionFunction* function) const {
+  return CurrentWindowForFunctionWithFilter(
+      function, windows_util::GetDefaultWindowTypeFilters());
+}
+
+WindowController* WindowControllerList::CurrentWindowForFunctionWithFilter(
+    const UIThreadExtensionFunction* function,
+    const WindowTypeFilter& filter) const {
   WindowController* result = NULL;
   // Returns either the focused window (if any), or the last window in the list.
   for (ControllerList::const_iterator iter = windows().begin();
        iter != windows().end(); ++iter) {
-    if (windows_util::CanOperateOnWindow(function, *iter)) {
+    if (windows_util::CanOperateOnWindow(function, *iter, filter)) {
       result = *iter;
       if (result->window()->IsActive())
         break;  // use focused window
     }
   }
   return result;
 }
 
 }  // namespace extensions