extensions: windows: list all windows from the current profile

chrome/browser/extensions/api/tabs/windows_util.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_WINDOWS_UTIL_H__
 #define CHROME_BROWSER_EXTENSIONS_API_TABS_WINDOWS_UTIL_H__
 
+#include "chrome/browser/extensions/window_controller_list.h"
+#include "chrome/common/extensions/api/windows.h"
+
 class UIThreadExtensionFunction;
 
+namespace content {
+class BrowserContext;
+}
+
 namespace extensions {
+class Extension;
 class WindowController;
 }
 
 namespace windows_util {
 
+const extensions::WindowTypeFilter& GetDefaultWindowTypeFilters();
+
+const extensions::WindowTypeFilter& GetNoWindowTypeFilters();

[not at google - send to devlin, 2015/07/31 21:48:03]

Could you comment all of these new functions?

[llandwerlin-old, 2015/08/03 10:11:54]

Done.

+
+bool WindowMatchesTypeFilter(const extensions::WindowController* controller,
+                             const extensions::WindowTypeFilter& filters);
+
 // Populates |controller| for given |window_id|. If the window is not found,
 // returns false and sets UIThreadExtensionFunction error_.
 bool GetWindowFromWindowID(UIThreadExtensionFunction* function,
                            int window_id,
+                           const extensions::WindowTypeFilter& type_filter,
                            extensions::WindowController** controller);
 
 // Returns true if |function| (and the profile and extension that it was
 // invoked from) can operate on the window wrapped by |window_controller|.
+// If |all_window_types| is set this function will return true for any
+// kind of window (including app and devtools), otherwise it will
+// return true only for normal browser windows as well as windows
+// created by the extension.
 bool CanOperateOnWindow(const UIThreadExtensionFunction* function,
-                        const extensions::WindowController* controller);
+                        const extensions::WindowController* controller,
+                        const extensions::WindowTypeFilter& type_filter);
+
+// Same as |CanOperateOnWindow| but uses |extension| and |browser_context|
+// instead of a UIThreadExtensionFunction.
+bool ExtensionCanOperateOnWindow(
+    const extensions::Extension* extension,
+    content::BrowserContext* browser_context,

[not at google - send to devlin, 2015/07/31 21:48:03]

I'd just change CanOperateOnWindow to take a BrowserContext/Extension rather
than having 2 separate versions. There are only a few call sites.

It would be nice if GetWindowFromWindowID were given the same treatment, but
that has too many dependencies unfortunately.

(also, nitty, but prefer arguments to be passed in in order of generality, so
BrowserContext would go before Extension).

[llandwerlin-old, 2015/08/03 10:11:54]

Sorry, this isn't used anymore. Removing.

+    const extensions::WindowController* controller,
+    const extensions::WindowTypeFilter& type_filter);
 
 }  // namespace windows_util
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_TABS_WINDOWS_UTIL_H__