extensions: windows: list all windows from the current profile

chrome/common/extensions/permissions/chrome_api_permissions.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/chrome_api_permissions.h"
 
 #include "chrome/grit/generated_resources.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/api_permission_set.h"
 #include "extensions/common/permissions/media_galleries_permission.h"
 #include "extensions/common/permissions/permission_message.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "extensions/strings/grit/extensions_strings.h"
 
 namespace extensions {
 
 namespace {
 
 const char kWindowsPermission[] = "windows";
+const char kWindowsGlobalPermission[] = "windows.global";
 
 template <typename T>
 APIPermission* CreateAPIPermission(const APIPermissionInfo* permission) {
   return new T(permission);
 }
 
 }  // namespace
 
 std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()
     const {
@@ skipping 152 matching lines @@
       {APIPermission::kSyncFileSystem,
        "syncFileSystem",
        APIPermissionInfo::kFlagNone,
        IDS_EXTENSION_PROMPT_WARNING_SYNCFILESYSTEM,
        PermissionMessage::kSyncFileSystem},
       {APIPermission::kTab,
        "tabs",
        APIPermissionInfo::kFlagNone,
        IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,
        PermissionMessage::kTabs},
+      {APIPermission::kTabGlobal,
+       "tabs.global",
+       APIPermissionInfo::kFlagNone,
+       IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,

[not at google - send to devlin, 2015/04/20 16:47:43]

Extensions can usually enumerate Chrome tabs/windows without any permission. The
tabs/windows permissions just give them access to sensitive data like the URL.

It makes sense to me to continue that behavior, which is to say, don't make
tabs.global/windows.global require a permission warning, and don't make it grant
access to data like the URL.

Also I think that windows.global is enough, no reason to have the tabs.global
alias.

[llandwerlin-old, 2015/06/26 11:26:14]

Done.

[not at google - send to devlin, 2015/06/30 17:33:53]

Mm actually I need to think about this a little bit more. It's the right thing
to do to (a) force extensions to opt-in to getting global windows (otherwise
it's not backwards compatible), and (b) not require an install warning just to
do so.

However, it's also useful to read the URLs (like the extensions) of windows,
which does require an install warning.

My current thinking is to actually use an entirely different namespace for this,
like chrome.windows.global.query/remove/onCreated/onUpdated/..., then to have
the windows.global permission give access to the URLs and so on. That would be
both backwards compatible and fairly clean.

But that's probably a much larger change, and I'm sure we can carve out plenty
of code to submit before making that decision (like all of the event routing and
querying stuff, most of the app window router).

Sorry to drop this on you now.

Another option would be to have 2 separate permissions but instinctively that
sounds confusing.

+       PermissionMessage::kTabsGlobal},
       {APIPermission::kTopSites,
        "topSites",
        APIPermissionInfo::kFlagNone,
        IDS_EXTENSION_PROMPT_WARNING_TOPSITES,
        PermissionMessage::kTopSites},
       {APIPermission::kTts, "tts", 0, APIPermissionInfo::kFlagCannotBeOptional},
       {APIPermission::kTtsEngine,
        "ttsEngine",
        APIPermissionInfo::kFlagCannotBeOptional,
        IDS_EXTENSION_PROMPT_WARNING_TTS_ENGINE,
@@ skipping 244 matching lines @@
   for (size_t i = 0; i < arraysize(permissions_to_register); ++i)
     permissions.push_back(new APIPermissionInfo(permissions_to_register[i]));
   return permissions;
 }
 
 std::vector<PermissionsProvider::AliasInfo>
 ChromeAPIPermissions::GetAllAliases() const {
   // Register aliases.
   std::vector<PermissionsProvider::AliasInfo> aliases;
   aliases.push_back(PermissionsProvider::AliasInfo("tabs", kWindowsPermission));
+  aliases.push_back(
+      PermissionsProvider::AliasInfo("tabs.global", kWindowsGlobalPermission));
   return aliases;
 }
 
 }  // namespace extensions