Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1099483002: Use alias_for with trivial property aliases

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1099483002: Use alias_for with trivial property aliases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@alias

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt ('K') | « Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index f9d9c765d82905cf71688863fa7bd033ebfa347d..9270b73c03f67d79eed8c54ed71f951f512a8b66 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -288,7 +288,6 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyWebkitAppearance:

return (valueID >= CSSValueCheckbox && valueID <= CSSValueTextarea) || valueID == CSSValueNone;

case CSSPropertyBackfaceVisibility:

- case CSSPropertyWebkitBackfaceVisibility:

return valueID == CSSValueVisible || valueID == CSSValueHidden;

case CSSPropertyMixBlendMode:

ASSERT(RuntimeEnabledFeatures::cssCompositingEnabled());

@@ -345,7 +344,6 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyWebkitTextSecurity: // disc | circle | square | none

return valueID == CSSValueDisc || valueID == CSSValueCircle || valueID == CSSValueSquare || valueID == CSSValueNone;

case CSSPropertyTransformStyle:

- case CSSPropertyWebkitTransformStyle:

return valueID == CSSValueFlat || valueID == CSSValuePreserve3d;

case CSSPropertyWebkitUserDrag: // auto | none | element

return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueElement;

@@ -414,7 +412,6 @@ bool CSSParserFastPaths::isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyVisibility:

case CSSPropertyWebkitAppearance:

case CSSPropertyBackfaceVisibility:

- case CSSPropertyWebkitBackfaceVisibility:

case CSSPropertyWebkitBorderAfterStyle:

case CSSPropertyWebkitBorderBeforeStyle:

case CSSPropertyWebkitBorderEndStyle:

@@ -446,7 +443,6 @@ bool CSSParserFastPaths::isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyWebkitTextEmphasisPosition:

case CSSPropertyWebkitTextSecurity:

case CSSPropertyTransformStyle:

- case CSSPropertyWebkitTransformStyle:

case CSSPropertyWebkitUserDrag:

case CSSPropertyWebkitUserModify:

case CSSPropertyWebkitUserSelect:

@@ -658,6 +654,7 @@ static PassRefPtrWillBeRawPtr<CSSValue> parseSimpleTransform(CSSPropertyID prope

PassRefPtrWillBeRawPtr<CSSValue> CSSParserFastPaths::maybeParseValue(CSSPropertyID propertyID, const String& string, CSSParserMode parserMode)

{

+ propertyID = resolveCSSPropertyID(propertyID);

if (RefPtrWillBeRawPtr<CSSValue> length = parseSimpleLengthValue(propertyID, string, parserMode))

return length.release();

if (RefPtrWillBeRawPtr<CSSValue> color = parseColorValue(propertyID, string, parserMode))