Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1099473004: Reland "Refactor compilation dependency handling." (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Refactor compilation dependency handling." R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/f557d75360d34d7d29834c4864f4154849ed404d Cr-Commit-Position: refs/heads/master@{#27945}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -234 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compilation-dependencies.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/compilation-dependencies.cc View 1 chunk +121 lines, -0 lines 0 comments Download
M src/compiler.h View 5 chunks +4 lines, -34 lines 0 comments Download
M src/compiler.cc View 7 chunks +7 lines, -58 lines 0 comments Download
M src/hydrogen.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +10 lines, -13 lines 0 comments Download
M src/lithium.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 8 chunks +3 lines, -25 lines 0 comments Download
M src/objects.cc View 7 chunks +8 lines, -78 lines 0 comments Download
M test/cctest/test-migrations.cc View 6 chunks +14 lines, -19 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
PTAL
5 years, 8 months ago (2015-04-20 13:56:56 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
5 years, 8 months ago (2015-04-20 14:56:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099473004/20001
5 years, 8 months ago (2015-04-20 14:57:37 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-20 15:22:07 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 15:22:17 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f557d75360d34d7d29834c4864f4154849ed404d
Cr-Commit-Position: refs/heads/master@{#27945}

Powered by Google App Engine
This is Rietveld 408576698