content/browser/appcache/appcache_update_job.cc - Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_update_job.cc

Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change WalletServiceUrl::IsSignInContinueUrl to use SchemeIsCryptographic. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('K') | « components/content_settings/core/browser/host_content_settings_map.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_update_job.cc

diff --git a/content/browser/appcache/appcache_update_job.cc b/content/browser/appcache/appcache_update_job.cc

index 4b212861222e0f15a560f871888c4f64860f7ed2..708b42c32a2996f93fc988ec50bccec5c13d9b80 100644

--- a/content/browser/appcache/appcache_update_job.cc

+++ b/content/browser/appcache/appcache_update_job.cc

@@ -169,7 +169,7 @@ void AppCacheUpdateJob::URLFetcher::OnResponseStarted(

return;

}

- if (url_.SchemeIsSecure()) {

+ if (url_.SchemeIsCryptographic()) {

// Do not cache content with cert errors.

// Also, we willfully violate the HTML5 spec at this point in order

// to support the appcaching of cross-origin HTTPS resources.