chrome/browser/banners/app_banner_manager.cc - Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase onto the moved version of IsOriginSecure (https://codereview.chromium.org/1101033003/). Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_context_uma_util.cc » ('j') | chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_manager.cc

diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc

index 6fdd5cf1c0fea885c956f7c3bb58acf210e62c43..786d389c32a2b24b2f49d6b4e997d5ebf817c012 100644

--- a/chrome/browser/banners/app_banner_manager.cc

+++ b/chrome/browser/banners/app_banner_manager.cc

@@ -11,6 +11,7 @@

#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/frame_navigate_params.h"

+#include "content/public/common/origin_util.h"

#include "net/base/load_flags.h"

#include "ui/gfx/screen.h"

@@ -47,9 +48,9 @@ void AppBannerManager::DidFinishLoad(

return;

}

- // A secure scheme is required to show banners, so exit early if we see the

+ // A secure origin is required to show banners, so exit early if we see the

palmer 2015/04/30 19:05:11 Nit: I think you can make this comment more concis

// URL is invalid.

- if (!validated_url.SchemeIsSecure() && !gDisableSecureCheckForTesting)

+ if (!IsOriginSecure(validated_url) && !gDisableSecureCheckForTesting)

return;

// Kick off the data retrieval pipeline.