components/content_settings/core/browser/host_content_settings_map.cc - Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nhiroki's comment. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/content_settings/core/browser/host_content_settings_map.cc

diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc

index 74076c5d77eac8e0065ccb5550162e3b6dd298dd..79b882cb3bfe5e2529101ff59b20661a13c7eb10 100644

--- a/components/content_settings/core/browser/host_content_settings_map.cc

+++ b/components/content_settings/core/browser/host_content_settings_map.cc

@@ -13,6 +13,7 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "base/time/clock.h"

+#include "chrome/common/origin_util.h"

#include "components/content_settings/core/browser/content_settings_default_provider.h"

#include "components/content_settings/core/browser/content_settings_details.h"

#include "components/content_settings/core/browser/content_settings_observable_provider.h"

@@ -654,7 +655,7 @@ bool HostContentSettingsMap::ShouldAllowAllContent(

#endif

if (secondary_url.SchemeIs(kChromeUIScheme) &&

content_type == CONTENT_SETTINGS_TYPE_COOKIES &&

- primary_url.SchemeIsSecure()) {

+ IsOriginSecure(primary_url)) {

return true;

}

#if defined(ENABLE_EXTENSIONS)

« components/content_settings/core/browser/DEPS ('K') | « components/content_settings/core/browser/DEPS ('k') | content/browser/DEPS » ('j') | content/browser/DEPS » ('J')