chrome/browser/media/media_stream_infobar_delegate.cc - Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/media_stream_infobar_delegate.cc

Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nhiroki's comment. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_manager.cc ('K') | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('j') | components/autofill/content/browser/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/media_stream_infobar_delegate.cc

diff --git a/chrome/browser/media/media_stream_infobar_delegate.cc b/chrome/browser/media/media_stream_infobar_delegate.cc

index c5940b8ee8e2ac0df5b0644856337b9ee7761771..8002e9e6b30bc0f998f606973f0a030f1adc1cfd 100644

--- a/chrome/browser/media/media_stream_infobar_delegate.cc

+++ b/chrome/browser/media/media_stream_infobar_delegate.cc

@@ -8,6 +8,7 @@

#include "base/metrics/histogram.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/infobars/infobar_service.h"

+#include "chrome/common/origin_util.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

#include "components/google/core/browser/google_util.h"

@@ -115,7 +116,7 @@ base::string16 MediaStreamInfoBarDelegate::GetButtonLabel(

bool MediaStreamInfoBarDelegate::Accept() {

GURL origin(controller_->GetSecurityOriginSpec());

- if (origin.SchemeIsSecure()) {

+ if (IsOriginSecure(origin)) {

UMA_HISTOGRAM_ENUMERATION("Media.DevicePermissionActions",

kAllowHttps, kPermissionActionsMax);

} else {