content/browser/appcache/appcache_update_job.cc - Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_update_job.cc

Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove an ad-hoc definition of IsSchemeSecure() from a header file. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/DEPS ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_update_job.cc

diff --git a/content/browser/appcache/appcache_update_job.cc b/content/browser/appcache/appcache_update_job.cc

index 4b212861222e0f15a560f871888c4f64860f7ed2..881e23b4f4b63cfd5dd219855c0e7605ac3e83c5 100644

--- a/content/browser/appcache/appcache_update_job.cc

+++ b/content/browser/appcache/appcache_update_job.cc

@@ -10,6 +10,7 @@

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/thread_task_runner_handle.h"

+#include "chrome/common/origin_util.h"

#include "content/browser/appcache/appcache_group.h"

#include "content/browser/appcache/appcache_histograms.h"

#include "content/public/browser/browser_thread.h"

@@ -169,7 +170,7 @@ void AppCacheUpdateJob::URLFetcher::OnResponseStarted(

return;

}

- if (url_.SchemeIsSecure()) {

+ if (url_.SchemeIsCryptographic()) {

// Do not cache content with cert errors.

// Also, we willfully violate the HTML5 spec at this point in order

// to support the appcaching of cross-origin HTTPS resources.