Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1099453004: Disable flaky tests on Linux Release (AMD) GPU FYI (Closed)

Created:
5 years, 8 months ago by ericrk
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky tests on Linux Release (AMD) GPU FYI Disables several flaky tests which cause Linux Release (AMD) GPU FYI to occasionally fail. These tests are not disabled on other bots, and each case has a bug filed for it. Disabled test cases: ContextLost.WebGLContextLostFromGPUProcessExit WebglConformance.conformance_textures_texture_size_cube_maps WebglConformance.conformance_textures_texture_mips WebglConformance.conformance_glsl_misc_shaders_with_invariance BUG=479975, 479983, 479981, 479952 Committed: https://crrev.com/29f2a0621c72c78b0f44b4d19a6ddd3c90fc8911 Cr-Commit-Position: refs/heads/master@{#326670}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Re-add "sample usage" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/test/gpu/gpu_tests/context_lost_expectations.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ericrk
Is there an easy way to try this change out before submission?
5 years, 8 months ago (2015-04-22 22:21:39 UTC) #2
Jamie Madill
Looks good (not an owner) https://codereview.chromium.org/1099453004/diff/1/content/test/gpu/gpu_tests/context_lost_expectations.py File content/test/gpu/gpu_tests/context_lost_expectations.py (right): https://codereview.chromium.org/1099453004/diff/1/content/test/gpu/gpu_tests/context_lost_expectations.py#newcode13 content/test/gpu/gpu_tests/context_lost_expectations.py:13: ['linux', ('amd', 0x6779)], bug=479975) ...
5 years, 8 months ago (2015-04-23 12:29:27 UTC) #3
Jamie Madill
Also, I don't know of any way to test without submitting as AMD isn't on ...
5 years, 8 months ago (2015-04-23 12:29:50 UTC) #4
Ken Russell (switch to Gerrit)
Yes, unfortunately there's no way to try this change on the AMD bot. However, the ...
5 years, 8 months ago (2015-04-23 17:44:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099453004/20001
5 years, 8 months ago (2015-04-23 20:11:29 UTC) #8
ericrk
Sounds good, sample usage re-added. Submitting now - will follow up and make sure this ...
5 years, 8 months ago (2015-04-23 20:12:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 22:15:39 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:17:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29f2a0621c72c78b0f44b4d19a6ddd3c90fc8911
Cr-Commit-Position: refs/heads/master@{#326670}

Powered by Google App Engine
This is Rietveld 408576698