content/renderer/media/webrtc/media_stream_track_metrics.cc - Issue 1099453002: base: Simplify the construction of MD5Digest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_track_metrics.cc

Issue 1099453002: base: Simplify the construction of MD5Digest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webrtc/media_stream_track_metrics.cc

diff --git a/content/renderer/media/webrtc/media_stream_track_metrics.cc b/content/renderer/media/webrtc/media_stream_track_metrics.cc

index 0ec4444582b1e07b59ce5d465bfb7a6187b69cf0..41b11b1908e5d64a7b7e380eb2b0fd7cb3fae88a 100644

--- a/content/renderer/media/webrtc/media_stream_track_metrics.cc

+++ b/content/renderer/media/webrtc/media_stream_track_metrics.cc

@@ -389,8 +389,8 @@ uint64 MediaStreamTrackMetrics::MakeUniqueIdImpl(uint64 pc_id,

base::MD5Digest digest;

base::MD5Final(&digest, &ctx);

- static_assert(sizeof(digest.a) > sizeof(uint64), "need a bigger digest");

- return *reinterpret_cast<uint64*>(digest.a);

+ static_assert(sizeof(digest) > sizeof(uint64), "need a bigger digest");

+ return *reinterpret_cast<uint64*>(digest);

}

uint64 MediaStreamTrackMetrics::MakeUniqueId(const std::string& track_id,