Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 109943003: IDL compiler: [ConstructorCallWith] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add FIXME Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/unstable/v8_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 0ea8c6005b91bfc51cb771febaa28b5b9c119578..25df7b736b8a000411123e74f0b1f96db803c5d7 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -2755,10 +2755,11 @@ END
$code .= $parameterCheckString;
if ($interface->extendedAttributes->{"ConstructorCallWith"}) {
- if ($interface->extendedAttributes->{"ConstructorCallWith"} eq "ExecutionContext") {
+ if (ExtendedAttributeContains($interface->extendedAttributes->{"ConstructorCallWith"}, "ExecutionContext")) {
push(@beforeArgumentList, "context");
$code .= " ExecutionContext* context = getExecutionContext();\n";
- } elsif ($interface->extendedAttributes->{"ConstructorCallWith"} eq "Document") {
+ }
+ if (ExtendedAttributeContains($interface->extendedAttributes->{"ConstructorCallWith"}, "Document")) {
push(@beforeArgumentList, "document");
$code .= " Document& document = *toDocument(getExecutionContext());\n";
}
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/unstable/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698