Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 109943003: IDL compiler: [ConstructorCallWith] (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, gasubic, philipj_slow, eae+blinkwatch, tommyw+watchlist_chromium.org, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, nessy, adamk+blink_chromium.org, Raymond Toy, Nate Chapin, watchdog-blink-watchlist_google.com, vcarbune.chromium, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [ConstructorCallWith] Straightforward, with one twist: * Modify Perl to allow multiple [ConstructorCallWith] values This simplifies testing (we don't need 2 separate IDL files to test them), and is consistent with [CallWith]. Also IDL style fixes. BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163410

Patch Set 1 #

Patch Set 2 : Add FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -51 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 4 chunks +21 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceConstructor.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/dom/Comment.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentFragment.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Range.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaController.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/workers/Worker.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.idl View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/WebKitNotification.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-09 06:57:33 UTC) #1
haraken
LGTM for now, but we want to deprecate [ConstructorCallWith=Document] in a follow-up CL. [ConstructorCallWith=ExecutionContext] will ...
7 years ago (2013-12-09 07:03:30 UTC) #2
Nils Barth (inactive)
On 2013/12/09 07:03:30, haraken wrote: > LGTM for now, but we want to deprecate [ConstructorCallWith=Document] ...
7 years ago (2013-12-09 07:25:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/109943003/20001
7 years ago (2013-12-09 07:25:59 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-09 08:45:10 UTC) #5
Message was sent while issue was closed.
Change committed as 163410

Powered by Google App Engine
This is Rietveld 408576698