Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1099403008: content: Add SharedBitmap MemoryDumpProvider implementation. (Closed)

Created:
5 years, 8 months ago by reveman
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Add SharedBitmap MemoryDumpProvider implementation. BUG=481413 Committed: https://crrev.com/cc84bf65663fe7003883db722f38e1e8af2f21c9 Cr-Commit-Position: refs/heads/master@{#327447}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Remove kNameInnerSize #

Total comments: 4

Patch Set 4 : use base::HexEncode and register in BrowserMainLoop::MainMessageLoopStart instead #

Patch Set 5 : remove includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M content/browser/browser_main_loop.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M content/common/host_shared_bitmap_manager.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 1 2 3 4 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reveman
5 years, 7 months ago (2015-04-28 21:07:13 UTC) #2
jbauman
lgtm
5 years, 7 months ago (2015-04-28 21:10:34 UTC) #3
Primiano Tucci (use gerrit)
LGTM % task_runner affinity (or this will hit a DCHEK in the MDM::UnregisterDumpProvider) https://codereview.chromium.org/1099403008/diff/40001/content/common/host_shared_bitmap_manager.cc File ...
5 years, 7 months ago (2015-04-28 21:40:07 UTC) #4
reveman
+avi for content/ https://codereview.chromium.org/1099403008/diff/40001/content/common/host_shared_bitmap_manager.cc File content/common/host_shared_bitmap_manager.cc (right): https://codereview.chromium.org/1099403008/diff/40001/content/common/host_shared_bitmap_manager.cc#newcode101 content/common/host_shared_bitmap_manager.cc:101: this); On 2015/04/28 21:40:06, Primiano Tucci ...
5 years, 7 months ago (2015-04-29 01:45:58 UTC) #6
Avi (use Gerrit)
LGTM stampity stamp
5 years, 7 months ago (2015-04-29 02:18:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099403008/80001
5 years, 7 months ago (2015-04-29 03:55:17 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-04-29 07:51:05 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 07:51:54 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cc84bf65663fe7003883db722f38e1e8af2f21c9
Cr-Commit-Position: refs/heads/master@{#327447}

Powered by Google App Engine
This is Rietveld 408576698