chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h - Issue 1099403005: [AiS] changing mac omnibox suggestions form NSMatrix to NSTableView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

Issue 1099403005: [AiS] changing mac omnibox suggestions form NSMatrix to NSTableView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: autorelease on column data cell Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix_unittest.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

index 29ec953aad14f530727e5911fa3506f93af7fe76..f4159e6cb1b9a77c46b333808355f8362afd317b 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

@@ -46,6 +46,9 @@ class OmniboxPopupViewMac : public OmniboxPopupView,

void OnMatrixRowMiddleClicked(OmniboxPopupMatrix* matrix,

size_t row) override;

+ // Returns the NSImage that should be used as an icon for the given match.

+ NSImage* ImageForMatch(const AutocompleteMatch& match) const;

OmniboxPopupMatrix* matrix() { return matrix_; }

protected:

@@ -65,9 +68,6 @@ class OmniboxPopupViewMac : public OmniboxPopupView,

// change.

void PositionPopup(const CGFloat matrixHeight);

- // Returns the NSImage that should be used as an icon for the given match.

- NSImage* ImageForMatch(const AutocompleteMatch& match) const;

// Opens the URL at the given row.

void OpenURLForRow(size_t row, WindowOpenDisposition disposition);